Skip to content

CSPL-4358 Split BusConfiguration CR into 2 CRs - Queue and ObjectStorage#1643

Open
kasiakoziol wants to merge 27 commits intoCSPL-3551-ingestion-crfrom
feature/CSPL-4358-split-bus-into-2-crs
Open

CSPL-4358 Split BusConfiguration CR into 2 CRs - Queue and ObjectStorage#1643
kasiakoziol wants to merge 27 commits intoCSPL-3551-ingestion-crfrom
feature/CSPL-4358-split-bus-into-2-crs

Conversation

@kasiakoziol
Copy link
Collaborator

@kasiakoziol kasiakoziol commented Dec 12, 2025

Depends On

Description

It splits BusConfiguration CR into 2 CRs - Queue and ObjectStorage as per internal documentation.

Key Changes

  • New CRs - Queue and ObjectStorage
  • Validations added to new CRs
  • Updated documentation and Helm charts

Testing and Verification

  • Manual tests
  • Automated tests

Related Issues

Jira: https://splunk.atlassian.net/browse/CSPL-4358

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

coveralls commented Dec 12, 2025

Pull Request Test Coverage Report for Build 21821066449

Details

  • 263 of 550 (47.82%) changed or added relevant lines in 11 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.4%) to 84.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/splunk/enterprise/types.go 0 4 0.0%
pkg/splunk/enterprise/upgrade.go 0 4 0.0%
pkg/splunk/enterprise/objectstorage.go 31 40 77.5%
pkg/splunk/enterprise/queue.go 31 40 77.5%
pkg/splunk/enterprise/ingestorcluster.go 108 129 83.72%
pkg/splunk/enterprise/util.go 14 35 40.0%
internal/controller/indexercluster_controller.go 2 63 3.17%
internal/controller/ingestorcluster_controller.go 2 63 3.17%
pkg/splunk/enterprise/indexercluster.go 73 170 42.94%
Files with Coverage Reduction New Missed Lines %
internal/controller/indexercluster_controller.go 7 38.1%
internal/controller/ingestorcluster_controller.go 7 38.46%
Totals Coverage Status
Change from base Build 19886830069: -1.4%
Covered Lines: 11247
Relevant Lines: 13387

💛 - Coveralls

@kasiakoziol kasiakoziol changed the title CSPL-4358 Split BusConfiguration CR into 2 CRs - Bus and LargeMessageStore CSPL-4358 Split BusConfiguration CR into 2 CRs - Queue and ObjectStorage Dec 23, 2025
@kasiakoziol kasiakoziol marked this pull request as ready for review December 23, 2025 14:20
// +optional
// +kubebuilder:validation:Pattern=`^https?://[^\s/$.?#].[^\s]*$`
// S3-compatible Service endpoint
Endpoint string `json:"endpoint"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we expecting the endpoint to have the region. do we need region separately.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ObjectStorage doesn't have region field, relies on Path. But if Endpoint is constructed automatically somewhere, same China/GovCloud issue from PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The region in ObjectStorage is taken from Queue if it is provided over there

Copy link
Collaborator

@vivekr-splunk vivekr-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have approve with comments

Copy link
Collaborator

@vivekr-splunk vivekr-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments

@kasiakoziol
Copy link
Collaborator Author

kasiakoziol commented Feb 9, 2026

[EDIT: Addressed]
From Vivek: we should have clear names and mixes concern queue , bucket, access, secret, version. can we try something simple like CredentialSecretVersion

…est-index

Feature/CSPL-4360 Secret reference for Index & Ingestion separation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants